New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Fixing redirection issue for logged-in users #26105 #28166

Closed

yp05327 wants to merge 1 commit into go-gitea:main from yp05327:revert-26105

Contributor

yp05327 commented Nov 22, 2023

IMO the fix in #26105 is not good enough.
And I see that in #27028, we have already support check redirect_to in verifyAuthWithOptions.

Ttested in my local pc, #26005 will not disappear again after revert the patch from #26105.
So I think we can revert it now.


          revert

0ca3645

GiteaBot added the lgtm/need 2 label

pull-request-size bot added the size/XS label

Member

delvh commented Dec 30, 2023

Is this PR now obsolete with #28636?

lunny closed this

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 2 size/XS